Data Exchange, STEP - Refactor StepType selection#786
Merged
dpasukhi merged 2 commits intoOpen-Cascade-SAS:IRfrom Nov 1, 2025
Merged
Data Exchange, STEP - Refactor StepType selection#786dpasukhi merged 2 commits intoOpen-Cascade-SAS:IRfrom
dpasukhi merged 2 commits intoOpen-Cascade-SAS:IRfrom
Conversation
Replace static lastvalue and mutex with mutable member theLastValue; simplify Value() logic and use early returns
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the StepSelect_StepType::Value() method by eliminating thread-unsafe static variables and simplifying control flow. The main objective is to improve thread safety and code maintainability by replacing a static lastvalue variable (protected by a mutex) with an instance-level mutable member theLastValue.
Key changes:
- Removed static
lastvaluevariable and mutex-based synchronization, replacing them with a mutable member fieldtheLastValue - Restructured logic with early returns to reduce nesting and improve readability
- Updated variable naming to follow OCCT conventions (e.g.,
module→aModule,CN→aCN)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| StepSelect_StepType.hxx | Added theLastValue mutable member field and TCollection_AsciiString include |
| StepSelect_StepType.cxx | Refactored Value() method to use instance-level storage, applied early returns, and modernized variable naming |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace static lastvalue and mutex with mutable member theLastValue; simplify Value() logic and use early returns