Data Exchange, DE Wrapper - Reorganisation of plugin system for Configuration Nodes #696
Merged
dpasukhi merged 7 commits intoOpen-Cascade-SAS:IRfrom Sep 3, 2025
Merged
Conversation
…DE_Wrapper - Added Register and UnRegister methods to DE_ConfigurationNode for managing bindings with DE_Wrapper. - Introduced DE_MultiPluginHolder to facilitate registration of multiple configuration nodes simultaneously. - Created new plugin factory functions for various configuration nodes (DEBREP, DEXCAF, DEGLTF, DEIGES, DEOBJ, DEPLY, DESTEP, DESTL, DEVRML) to streamline their registration with DE_Wrapper. - Removed unnecessary DE_PluginHolder instances from individual configuration node implementations. - Updated CMake files to include newly created source files for each configuration node. - Implemented singleton patterns in draw commands to ensure plugins are registered only once during initialization.
a8cecf2 to
58b6bd5
Compare
… duplicate definition
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes the plugin system for DE configuration nodes by introducing a centralized registration mechanism. The changes move from individual plugin holders in configuration node implementations to a factory-based approach with singleton patterns in Draw commands.
Key changes:
- Added Register/UnRegister methods to DE_ConfigurationNode for managing bindings with DE_Wrapper
- Introduced DE_MultiPluginHolder and DEPLUGIN macro for multi-node registration
- Implemented singleton patterns in Draw commands to ensure one-time plugin registration
Reviewed Changes
Copilot reviewed 37 out of 37 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| DE_ConfigurationNode.hxx/cxx | Added Register/UnRegister methods for wrapper binding |
| DE_PluginHolder.hxx | Added DE_MultiPluginHolder template and DEPLUGIN macro |
| Various XSDRAW*.cxx | Added singleton functions for plugin registration |
| Various TKDExxx.cxx | New factory files using DEPLUGIN macro |
| Various ConfigurationNode.cxx | Removed individual DE_PluginHolder instances |
| FILES.cmake | Updated to include new factory source files |
…leton usage in XDEDRAW and XSDRAWDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.