Coding - Remove unused dependencies from TKXDEDRAW#650
Merged
dpasukhi merged 1 commit intoOpen-Cascade-SAS:masterfrom Jul 29, 2025
Merged
Coding - Remove unused dependencies from TKXDEDRAW#650dpasukhi merged 1 commit intoOpen-Cascade-SAS:masterfrom
dpasukhi merged 1 commit intoOpen-Cascade-SAS:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on removing unused dependencies from the TKXDEDRAW module by cleaning up unnecessary includes and dependencies. The changes eliminate redundant functionality by moving dimension type checking methods to their appropriate location and removing external library dependencies that are no longer needed.
- Removed unused dependency includes from TKXDEDRAW/XDEDRAW module files
- Moved dimension type checking methods from STEPCAFControl_GDTProperty to XCAFDimTolObjects_DimensionObject
- Updated external library dependencies to remove unused libraries
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| XSDRAWSTEP.cxx | Added STEPCAFControl_Controller include and initialization call |
| XDEDRAW_GDTs.cxx | Removed unused STEPCAFControl_GDTProperty include and updated method calls |
| XDEDRAW.cxx | Removed multiple unused DE* includes and STEPCAFControl initialization |
| EXTERNLIB.cmake | Removed unused external library dependencies |
| XCAFDimTolObjects_DimensionObject.hxx | Added declarations for dimension type checking methods |
| XCAFDimTolObjects_DimensionObject.cxx | Implemented dimension type checking methods |
| STEPCAFControl_Writer.cxx | Updated method calls to use new location |
| STEPCAFControl_GDTProperty.hxx | Removed dimension type checking method declarations |
| STEPCAFControl_GDTProperty.cxx | Removed dimension type checking method implementations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.