Configuration, CMake - Build config file is invalid#647
Merged
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom Jul 27, 2025
Merged
Configuration, CMake - Build config file is invalid#647dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
Conversation
Add OCCT_MAKE_COMPILER_BITNESS function and expand OCCT_CUSTOM_BUILD_BIN_LIB_PATHS variable
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a configuration issue in the CMake build system where template variable substitution was incomplete, causing invalid build configuration files. The fix addresses missing template variable expansion in both shell script templates and CMake configuration processing.
Key changes:
- Fixed missing
@delimiter in template variable substitution for QT directory detection - Added compiler bitness calculation before custom script generation
- Implemented nested variable expansion for custom build paths
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| adm/templates/custom.build.sh.in | Fixed template variable syntax for QT_DIR check |
| CMakeLists.txt | Added compiler bitness function call and nested variable expansion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@delimiter in template variable substitution for QT directory detection