Skip to content

Configuration, CMake - Disable build GLTF without RapidJSON#646

Merged
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
dpasukhi:gltf_disabling
Jul 27, 2025
Merged

Configuration, CMake - Disable build GLTF without RapidJSON#646
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
dpasukhi:gltf_disabling

Conversation

@dpasukhi
Copy link
Copy Markdown
Member

Exclude TKDEGLTF and TKXSDRAWGLTF toolkits when RapidJSON is disabled

Exclude TKDEGLTF and TKXSDRAWGLTF toolkits when RapidJSON is disabled
@dpasukhi dpasukhi added this to the Release 8.0 milestone Jul 26, 2025
@dpasukhi dpasukhi requested a review from Copilot July 26, 2025 17:22
@dpasukhi dpasukhi self-assigned this Jul 26, 2025
@dpasukhi dpasukhi added the 1. Configuration CMake/QMake processes of OCCT or samples label Jul 26, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the CMake configuration to properly exclude GLTF-related toolkits when RapidJSON is disabled. The change ensures that TKDEGLTF and TKXSDRAWGLTF toolkits are not built when RapidJSON usage is explicitly disabled by the user, preventing potential build failures due to missing dependencies.

  • Adds conditional logic to remove GLTF toolkits from build when RapidJSON is disabled
  • Provides informative status message about excluded toolkits

Comment thread CMakeLists.txt
@dpasukhi dpasukhi merged commit 9134c60 into Open-Cascade-SAS:IR Jul 27, 2025
45 of 46 checks passed
@dpasukhi dpasukhi deleted the gltf_disabling branch July 27, 2025 09:21
@github-project-automation github-project-automation bot moved this from Todo to Done in Maintenance Jul 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1. Configuration CMake/QMake processes of OCCT or samples

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants