Samples - CMake configuration fix#643
Merged
dpasukhi merged 3 commits intoOpen-Cascade-SAS:IRfrom Jul 25, 2025
Merged
Conversation
…braries for AndroidQt, FuncDemo, IESample, OCCTOverview, and Tutorial
- Created TriangulationSamples.h for triangulation sample implementation. - Added Viewer2d.xml to define 2D viewer menu items and their corresponding sample functions. - Implemented Viewer2dSamples.cxx and Viewer2dSamples.h to handle various 2D viewer samples including text, markers, fill areas, and grids. - Created Viewer3d.xml to define 3D viewer menu items for lighting and selection modes. - Implemented Viewer3dSamples.cxx and Viewer3dSamples.h to manage 3D viewer samples including light sources and shape presentations. - Updated ApplicationCommon.cxx to point to the correct sample source directory for the new 2D and 3D viewer samples.
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the CMake configuration for Qt samples by migrating from legacy text-based configuration files to proper CMake format with .cmake extensions. The changes enable better integration with modern CMake practices and improve the build system's maintainability.
Key changes:
- Converts text-based FILES, PACKAGES, and EXTERNLIB configuration files to CMake format
- Updates CMakeLists.txt files to use target-specific definitions instead of global ADD_DEFINITIONS
- Modifies qt_macro.cmake to work with the new variable-based file management system
Reviewed Changes
Copilot reviewed 50 out of 99 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| samples/qt/*/FILES.cmake | New CMake files defining source files for each sample |
| samples/qt/*/PACKAGES.cmake | New CMake files defining package lists for each sample |
| samples/qt/*/EXTERNLIB.cmake | New CMake files defining external library dependencies |
| samples/qt/*/CMakeLists.txt | Updated to use modern CMake practices with target-specific definitions |
| adm/cmake/qt_macro.cmake | Modified to work with the new CMake variable-based file system |
| CMakeLists.txt | Updated to load sample configuration files and correct file paths |
AtheneNoctuaPt
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.