Foundation classes - Include brackets type fix#635
Merged
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom Jul 22, 2025
Merged
Foundation classes - Include brackets type fix#635dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
Conversation
Validate the breckets for publick header files to be in <>
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes the include statement formatting for public header files by changing from quoted includes ("header.h") to angle bracket includes (<header.h>). This follows the common C++ convention where angle brackets are used for system/library headers and quoted includes are used for local project files.
Key Changes:
- Updates include statements to use angle brackets for foundation class headers
- Ensures consistent formatting across TKernel collection classes
- Applies the same formatting to FlexLexer header in STEP processing code
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| TCollection_AsciiString.lxx | Changes include format for TCollection_AsciiString.hxx |
| NCollection_UtfString.hxx | Updates include for NCollection_UtfString.lxx template implementation |
| NCollection_UtfIterator.hxx | Updates include for NCollection_UtfIterator.lxx template implementation |
| NCollection_String.hxx | Changes include format for NCollection_UtfString.hxx |
| NCollection_DynamicArray.hxx | Updates includes for NCollection_Allocator.hxx and NCollection_BasePointerVector.hxx |
| step.tab.hxx | Changes include format for FlexLexer.h |
AtheneNoctuaPt
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.