Skip to content

Configuration - Fix link errors on macOS when not building using vcpkg#609

Merged
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
iosdevzone:fix-macos-link-errors
Jul 13, 2025
Merged

Configuration - Fix link errors on macOS when not building using vcpkg#609
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
iosdevzone:fix-macos-link-errors

Conversation

@iosdevzone
Copy link
Copy Markdown
Contributor

@iosdevzone iosdevzone commented Jul 12, 2025

When building for macOS not using vcpkg, the build fails for some libraries because macOS-specific frameworks are not linked.

This problem is caused by this code in CMakeLists.txt

if (BUILD_USE_VCPKG)
  project (OCCT)
  if (APPLE)
    # set Apple specific variables
    occt_set_apple_csf_vars()
  endif()
endif()

This pull request moves the if (APPLE) block outside the if (BUILD_USE_VCPKG) which allows OCCT to built without errors from macOS.

@dpasukhi
Copy link
Copy Markdown
Member

dpasukhi commented Jul 12, 2025

Dear @iosdevzone

Thank you for your patch. To proceed with integration, please complete signing CLA process:
The links: Contribution Guide
Or https://dev.opencascade.org/get_involved

In case if you already have signed CLA, please share ID that OCCT team shared with your by email after accepting of CLA.

@dpasukhi dpasukhi added 1. Configuration CMake/QMake processes of OCCT or samples 3. CLA waited User need to process with CLA before review or integration processes labels Jul 12, 2025
@dpasukhi dpasukhi changed the title Fix link errors on macOS when not building using vcpkg. Configuration - Fix link errors on macOS when not building using vcpkg Jul 12, 2025
@iosdevzone
Copy link
Copy Markdown
Contributor Author

iosdevzone commented Jul 12, 2025

@dpasukhi Whoops! Sorry, overlooked this requirement. I just submitted the form. There are two submissions. In the first I omitted check a required checkbox.

@dpasukhi dpasukhi added 3. CLA approved User has the signed CLA and ready to review or integration processes and removed 3. CLA waited User need to process with CLA before review or integration processes labels Jul 12, 2025
@dpasukhi
Copy link
Copy Markdown
Member

dpasukhi commented Jul 12, 2025

Thank you, I see that all fields are filled.
At the moment, internal ID is not generated, it will be done on Monday. I will ask manager to do it right in the morning, before integrations to master.
No remarks from my side. Thank you for fix!

@dpasukhi dpasukhi self-requested a review July 12, 2025 21:28
@github-project-automation github-project-automation bot moved this from Todo to Integration in Maintenance Jul 12, 2025
@dpasukhi dpasukhi changed the base branch from master to IR July 12, 2025 21:31
@dpasukhi dpasukhi merged commit 878cd2f into Open-Cascade-SAS:IR Jul 13, 2025
23 checks passed
@github-project-automation github-project-automation bot moved this from Integration to Done in Maintenance Jul 13, 2025
@dpasukhi
Copy link
Copy Markdown
Member

dpasukhi commented Jul 13, 2025

CLA:
Submitted by iosdevzone
Sat, 07/12/2025 - 23:14

@dpasukhi dpasukhi added this to the Release 7.9.2 milestone Jul 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpasukhi dpasukhi dpasukhi approved these changes

Assignees

No one assigned

Labels

1. Configuration CMake/QMake processes of OCCT or samples 3. CLA approved User has the signed CLA and ready to review or integration processes

Projects

Maintenance
Status: Done

Milestone

Release 7.9.2

Development

Successfully merging this pull request may close these issues.

2 participants

@iosdevzone @dpasukhi