Foundation Classes - Optimize NCollection_Array1 with type specific#608
Merged
dpasukhi merged 3 commits intoOpen-Cascade-SAS:IRfrom Jul 12, 2025
Merged
Foundation Classes - Optimize NCollection_Array1 with type specific#608dpasukhi merged 3 commits intoOpen-Cascade-SAS:IRfrom
dpasukhi merged 3 commits intoOpen-Cascade-SAS:IRfrom
Conversation
Replaced parameterless construct() and destroy() methods with parameterized versions. Update is_arithmetic checks to is_trivial to avoid extra iterations
…ly_* traits for better type handling
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the NCollection_Array1 class by replacing parameterless construct() and destroy() methods with parameterized versions and updating type trait checks from is_arithmetic to more precise trivial type checks. The changes aim to improve performance by avoiding unnecessary iterations and providing more accurate type-based optimizations.
- Replaced parameterless
construct()anddestroy()methods with parameterized versions that specify ranges - Updated type trait checks from
is_arithmetictois_trivially_default_constructibleandis_trivially_destructible - Removed redundant local variable
anOldSizein theResizemethod
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced parameterless construct() and destroy() methods with parameterized versions.
Update is_arithmetic checks to is_trivial to avoid extra iterations