Skip to content

Testing - Daily vcpkg package validation#605

Merged
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
dpasukhi:packages_renenew
Jul 12, 2025
Merged

Testing - Daily vcpkg package validation#605
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
dpasukhi:packages_renenew

Conversation

@dpasukhi
Copy link
Copy Markdown
Member

Add daily workflow for configuring OCCT with vcpkg on multiple platforms

Add daily workflow for configuring OCCT with vcpkg on multiple platforms
@dpasukhi dpasukhi added this to the Release 8.0 milestone Jul 12, 2025
@dpasukhi dpasukhi requested a review from Copilot July 12, 2025 11:33
@dpasukhi dpasukhi self-assigned this Jul 12, 2025
@dpasukhi dpasukhi added 2. Enhancement New feature or request 1. Testing Updating of the DRAW/GTests or GH tests labels Jul 12, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new daily GitHub Actions workflow to configure OCCT with vcpkg on multiple platforms and refactors shared configuration steps into a composite action.

  • Introduce .github/workflows/daily-ir-vcpkg-configure.yml to run OCCT configuration daily on the IR branch for Windows, macOS, and Ubuntu.
  • Create a configure-occt composite action to encapsulate vcpkg setup and CMake configuration per platform.
  • Update the build-occt action to reuse the new configure-occt step instead of duplicating configuration logic.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/daily-ir-vcpkg-configure.yml New scheduled workflow for daily OCCT vcpkg configuration on IR branch
.github/actions/configure-occt/action.yml Composite action for setting up vcpkg and running platform-specific CMake
.github/actions/build-occt/action.yml Refactored to invoke configure-occt instead of inline configuration steps
Comments suppressed due to low confidence (2)

.github/actions/configure-occt/action.yml:111

  • The macOS configure step does not include the USE_VTK flag, so the use-vtk input isn’t applied. Please add -D USE_VTK=${{ inputs.use-vtk }} to ensure this setting is respected on macOS.
        cmake -G "Unix Makefiles" \

.github/workflows/daily-ir-vcpkg-configure.yml:13

  • [nitpick] The workflow defines three nearly identical jobs for Windows, macOS, and Linux. Consider using a matrix strategy to reduce duplication and simplify future platform additions.
jobs:

@dpasukhi dpasukhi merged commit 5643d5c into Open-Cascade-SAS:IR Jul 12, 2025
23 checks passed
@dpasukhi dpasukhi deleted the packages_renenew branch July 12, 2025 14:38
@github-project-automation github-project-automation bot moved this from Todo to Done in Maintenance Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1. Testing Updating of the DRAW/GTests or GH tests 2. Enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants