Testing - Adding ASCII code validation#593
Merged
dpasukhi merged 3 commits intoOpen-Cascade-SAS:IRfrom Jul 6, 2025
Merged
Conversation
Fixed issue with retest artifacts. Added ne job to check ASCII symbols
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new CI job to enforce ASCII-only characters in source files and refines the artifact upload logic for regression test retests.
- Split the existing regression test artifact upload into separate Windows and macOS/Linux steps with platform-specific paths.
- Added
ascii-checkjob in the build-and-test workflow to detect non-ASCII characters in changed files. - Introduced a new composite action (
.github/actions/ascii-check) to scan diffs and report any non-ASCII content.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/build-and-test-multiplatform.yml | Added ascii-check job to check for non-ASCII characters |
| .github/actions/retest-failures/action.yml | Refactored artifact upload into Windows and macOS/Linux steps |
| .github/actions/ascii-check/action.yml | New composite action to scan changed files for non-ASCII |
Comments suppressed due to low confidence (3)
.github/actions/ascii-check/action.yml:11
- [nitpick] The default
file-patternonly covers C++ files insrc/. Consider broadening or documenting this regex to include other relevant file types (e.g., scripts, configs, docs) or make it clearer that it targets only C++ sources.
default: '^(src)/.*\.(cpp|hxx|cxx|lxx|h|pxx|hpp)$'
.github/actions/retest-failures/action.yml:214
- [nitpick] The two platform-specific upload steps are nearly identical. You could simplify maintenance by using a matrix strategy or a single
usesstep with a conditionalpathexpression instead of duplicating the block.
- name: Upload regression test results (Windows)
.github/workflows/build-and-test-multiplatform.yml:38
- The
ascii-checkjob lacks an explicitneedsorifcondition to restrict it to pull requests. If it's only intended for PR validation, consider addingif: github.event_name == 'pull_request'or wiring it behindneeds: [other-job]to avoid unexpected runs.
ascii-check:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue with retest artifacts.
Added ne job to check ASCII symbols