Testing - Migration PR actions to VCPKG-based#587
Merged
Conversation
Update the default testing to use result of VCPKG. The 3rd-party are stored in GitHub NuGet storage and reused. The 3rd-party archive with installed 3rd-party added as an artefact
…pdate package installations for Linux
…rary fallback handling in CMake
…ld process for Clang
…orrect target triplet
- Updated CMakeLists.txt to streamline Tcl/Tk feature handling, removing unnecessary Windows checks. - Modified tcl.cmake and tk.cmake to eliminate WIN32-specific conditions for Vcpkg integration. - Removed obsolete patch files related to Tk build automation and added a new patch for Tk support. - Enhanced Makefile for Unix and Windows to include Tk build and install automation, along with clean and distclean targets. - Updated portfile.cmake to reflect changes in patch management and Tk directory handling.
This reverts commit d769939.
… include libx11 as a dependency
…ibx11 as a non-Windows dependency
… handling for vcpkg integration
…ses, including tar archive creation and extraction steps.
…the environment setup for Windows builds.
…cpkg cache action
…ependencies for vcpkg setup
…d nvidia-settings package for Linux builds
…s, Linux, and macOS
…n' feature for Mesa in vcpkg configuration
…s with Mesa-related packages
…le and TInspector
There was a problem hiding this comment.
Pull Request Overview
Migrates the testing and CI workflows to a VCPKG-based setup, replacing direct 3rd-party downloads with cached artifacts and integrating VCPKG into CMake builds.
- Introduce
vcpkg-setup,download-vcpkg-cache, andupload-vcpkg-cachecomposite actions, and wireGITHUB_TOKENthrough workflows. - Update CI jobs to fetch VCPKG cache instead of downloading zip archives and simplify apt/brew steps.
- Revise portfiles (especially Tcl/Tk) and CMake modules to support VCPKG manifests, Apple-specific settings, and new triplets.
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| adm/vcpkg/ports/tcl/portfile.cmake | Remove obsolete patches, add TKDIR_WIN, and introduce Tk build/install sections |
| adm/cmake/tcl.cmake | Add 3RDPARTY_TCL_LIBRARY_DIR and adjust fallback logic |
| .github/actions/run-tests/action.yml | Swap out 3rd-party zip downloads for download-vcpkg-cache step |
Comments suppressed due to low confidence (3)
.github/actions/run-tests/action.yml:98
- This hard-codes
vc14for Windows builds and no longer respects aclangconfiguration. It will break Windows-Clang workflows—restore the conditional logic to choose betweenvc14andclang.
call env.bat vc14 win64 release
.github/actions/run-gtest/action.yml:60
- Similar to
run-tests, this call always usesvc14and drops support for Windows-Clang builds. You should restore the conditional selection of the toolchain.
call env.bat vc14 win64 release
.github/actions/retest-failures/action.yml:159
- The retest-failures step also hard-codes
vc14, so clang-based Windows runs will never work. Restore the original templated expression to choose the correct environment.
call env.bat vc14 win64 release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the default testing to use result of VCPKG.
The 3rd-party are stored in GitHub NuGet storage and reused.
The 3rd-party archive with installed 3rd-party added as an artefact