Skip to content

Testing - Migration PR actions to VCPKG-based#587

Merged
dpasukhi merged 59 commits intoIRfrom
vcpkg_migration
Jul 6, 2025
Merged

Testing - Migration PR actions to VCPKG-based#587
dpasukhi merged 59 commits intoIRfrom
vcpkg_migration

Conversation

@dpasukhi
Copy link
Copy Markdown
Member

Update the default testing to use result of VCPKG.
The 3rd-party are stored in GitHub NuGet storage and reused.
The 3rd-party archive with installed 3rd-party added as an artefact

Update the default testing to use result of VCPKG.
The 3rd-party are stored in GitHub NuGet storage and reused.
The 3rd-party archive with installed 3rd-party added as an artefact
dpasukhi added 25 commits June 29, 2025 11:16
- Updated CMakeLists.txt to streamline Tcl/Tk feature handling, removing unnecessary Windows checks.
- Modified tcl.cmake and tk.cmake to eliminate WIN32-specific conditions for Vcpkg integration.
- Removed obsolete patch files related to Tk build automation and added a new patch for Tk support.
- Enhanced Makefile for Unix and Windows to include Tk build and install automation, along with clean and distclean targets.
- Updated portfile.cmake to reflect changes in patch management and Tk directory handling.
dpasukhi added 24 commits July 5, 2025 17:26
…ses, including tar archive creation and extraction steps.
@dpasukhi dpasukhi requested a review from Copilot July 6, 2025 12:14
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Migrates the testing and CI workflows to a VCPKG-based setup, replacing direct 3rd-party downloads with cached artifacts and integrating VCPKG into CMake builds.

  • Introduce vcpkg-setup, download-vcpkg-cache, and upload-vcpkg-cache composite actions, and wire GITHUB_TOKEN through workflows.
  • Update CI jobs to fetch VCPKG cache instead of downloading zip archives and simplify apt/brew steps.
  • Revise portfiles (especially Tcl/Tk) and CMake modules to support VCPKG manifests, Apple-specific settings, and new triplets.

Reviewed Changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 2 comments.

File Description
adm/vcpkg/ports/tcl/portfile.cmake Remove obsolete patches, add TKDIR_WIN, and introduce Tk build/install sections
adm/cmake/tcl.cmake Add 3RDPARTY_TCL_LIBRARY_DIR and adjust fallback logic
.github/actions/run-tests/action.yml Swap out 3rd-party zip downloads for download-vcpkg-cache step
Comments suppressed due to low confidence (3)

.github/actions/run-tests/action.yml:98

  • This hard-codes vc14 for Windows builds and no longer respects a clang configuration. It will break Windows-Clang workflows—restore the conditional logic to choose between vc14 and clang.
        call env.bat vc14 win64 release

.github/actions/run-gtest/action.yml:60

  • Similar to run-tests, this call always uses vc14 and drops support for Windows-Clang builds. You should restore the conditional selection of the toolchain.
        call env.bat vc14 win64 release

.github/actions/retest-failures/action.yml:159

  • The retest-failures step also hard-codes vc14, so clang-based Windows runs will never work. Restore the original templated expression to choose the correct environment.
        call env.bat vc14 win64 release

Comment thread adm/vcpkg/ports/tcl/portfile.cmake
Comment thread adm/cmake/tcl.cmake
@dpasukhi dpasukhi marked this pull request as ready for review July 6, 2025 12:22
@dpasukhi dpasukhi merged commit c0a6aee into IR Jul 6, 2025
66 of 68 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Maintenance Jul 6, 2025
@dpasukhi dpasukhi deleted the vcpkg_migration branch July 6, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants