Shape Healing - Reusing Surface Analysis for Wire fixing#565
Merged
dpasukhi merged 2 commits intoOpen-Cascade-SAS:IRfrom Jun 23, 2025
Merged
Shape Healing - Reusing Surface Analysis for Wire fixing#565dpasukhi merged 2 commits intoOpen-Cascade-SAS:IRfrom
dpasukhi merged 2 commits intoOpen-Cascade-SAS:IRfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the wire fixing functionality by enabling the reuse of prepared surface analysis from ShapeFix_Face for wire repairs. Key changes include:
- Addition of overloaded SetFace methods to accept both a face and a surface analysis object in ShapeFix_Wire and ShapeAnalysis_Wire.
- Updates in ShapeFix_Face to invoke the new overloads, ensuring the surface analysis object is propagated.
- Implementation of corresponding SetSurface methods in both ShapeFix_Wire and ShapeAnalysis_Wire.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/ModelingAlgorithms/TKShHealing/ShapeFix/ShapeFix_Wire.hxx | Added new overloads for SetFace and SetSurface to pass surface analysis. |
| src/ModelingAlgorithms/TKShHealing/ShapeFix/ShapeFix_Face.cxx | Updated calls to SetFace to forward the surface analysis object. |
| src/ModelingAlgorithms/TKShHealing/ShapeAnalysis/ShapeAnalysis_Wire.hxx | Added overloads for SetFace and SetSurface for surface analysis handling. |
| src/ModelingAlgorithms/TKShHealing/ShapeAnalysis/ShapeAnalysis_Wire.cxx | Implemented the new overloads for SetFace and SetSurface. |
Files not reviewed (1)
- src/ModelingAlgorithms/TKShHealing/ShapeFix/ShapeFix_Wire.lxx: Language not supported
ikochetkova
requested changes
May 30, 2025
Contributor
ikochetkova
left a comment
There was a problem hiding this comment.
I have one comment about the changes, please have a look.
| void SetFace(const TopoDS_Face& theFace, const Handle(ShapeAnalysis_Surface)& theSurfaceAnalysis); | ||
|
|
||
| //! Set surface analysis for the wire | ||
| Standard_EXPORT void SetSurface(const Handle(ShapeAnalysis_Surface)& theSurfaceAnalysis); |
Contributor
There was a problem hiding this comment.
Please update Standard_EXPORT macros using equal for equal inline (should they be?) methods.
Providing prepared analysis from ShapeFix_Face to wire.
3ba1856 to
9c1ac64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Providing prepared analysis from ShapeFix_Face to wire.