Configuration - Update minimum version of C++ to 17#537
Merged
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom May 16, 2025
Merged
Configuration - Update minimum version of C++ to 17#537dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
dpasukhi merged 1 commit intoOpen-Cascade-SAS:IRfrom
Conversation
Update C++ standard to C++17 in build configuration and documentation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the minimum C++ standard from C++14 to C++17 in both the build documentation and the GitHub Actions configuration.
- Updates the documented C++ standard versions in the build_occt markdown file
- Consistently replaces C++14 with C++17 in the GitHub Actions configuration for building OCCT
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dox/build/build_occt/building_occt.md | Updated the available list of C++ standard versions to reflect C++17 as the new minimum and added C++26 |
| .github/actions/build-occt/action.yml | Replaced occurrences of C++14 with C++17 in the build configuration |
Files not reviewed (2)
- CMakeLists.txt: Language not supported
- adm/cmake/occt_macros.cmake: Language not supported
Comments suppressed due to low confidence (1)
dox/build/build_occt/building_occt.md:121
- Verify that including C++26 in the list of selectable standards is intentional, as the PR title indicates updating the minimum C++ standard to C++17.
| BUILD_CPP_STANDARD | String | Select C++ standard (C++17, C++20, C++23, C++26) |
AtheneNoctuaPt
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update C++ standard to C++17 in build configuration and documentation