Testing - IR integration enable concurrency#536
Merged
dpasukhi merged 10 commits intoOpen-Cascade-SAS:IRfrom May 15, 2025
Merged
Testing - IR integration enable concurrency#536dpasukhi merged 10 commits intoOpen-Cascade-SAS:IRfrom
dpasukhi merged 10 commits intoOpen-Cascade-SAS:IRfrom
Conversation
Fix concurrency cancel-in-progress condition in CI workflow for IR branch
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue with the concurrency cancel-in-progress condition in the CI workflow for the IR branch.
- Updated the concurrency group expression to distinguish pull request events from other run types.
- Revised the cancel-in-progress expression to use github.head_ref for pull request events.
Comments suppressed due to low confidence (1)
.github/workflows/build-and-test-multiplatform.yml:23
- Verify that using github.head_ref for branch comparison in pull request events (instead of github.ref) is the intended behavior, ensuring it correctly identifies the IR branch.
&& !(github.head_ref == 'IR' && github.repository == 'Open-Cascade-SAS/OCCT')
…false' strings in workflow
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a concurrency cancel-in-progress issue in the CI workflow for the IR branch. The changes refactor the concurrency group and cancel-in-progress logic to account for pull request events versus other events.
- Updated concurrency group expression to differentiate between pull request and non-pull request events.
- Modified the cancel-in-progress condition to target the IR branch more accurately.
AtheneNoctuaPt
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix concurrency cancel-in-progress condition in CI workflow for IR branch