Skip to content

fix(desktop): upgrade electron to 39.3.0 to fix DevTools crash#9857

Merged
originalix merged 4 commits into
xfrom
chore/upgrade-electron-39.3.0
Jan 26, 2026
Merged

fix(desktop): upgrade electron to 39.3.0 to fix DevTools crash#9857
originalix merged 4 commits into
xfrom
chore/upgrade-electron-39.3.0

Conversation

@huhuanming

@huhuanming huhuanming commented Jan 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Upgrade electron from 39.2.7 to 39.3.0
  • Fix a potential race condition crash when opening DevTools

Related

Test plan

  • Verify desktop app builds and runs correctly
  • Test opening DevTools without crash

🤖 Generated with Claude Code

@revan-zhang

revan-zhang commented Jan 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

✅ Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@huhuanming huhuanming changed the title chore: upgrade electron to 39.3.0 fix(desktop): upgrade electron to 39.3.0 to fix DevTools crash Jan 23, 2026
@socket-security

socket-security Bot commented Jan 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Addedpassport-desktop-win32-x64-msvc@​0.1.2491003575100
Addedelectron-check-biometric-auth-changed@​1.0.0701006192100
Added@​onekeyfe/​electron-mac-icloud@​1.2.6731006693100
Addedpassport-desktop@​0.1.2731009976100
Added@​stoprocent/​noble@​2.3.48610010093100
Addedtailwindcss@​3.4.18981008797100

View full report

@huhuanming huhuanming enabled auto-merge (squash) January 23, 2026 11:28
@socket-security

socket-security Bot commented Jan 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
Obfuscated code: npm safer-buffer is 94.0% likely obfuscated

Confidence: 0.94

Location: Package overview

From: ? → npm/@onekeyfe/electron-mac-icloud@1.2.6 → npm/electron-check-biometric-auth-changed@1.0.0 → npm/@stoprocent/noble@2.3.4 → npm/safer-buffer@2.1.2

ℹ Read more on: This package | This alert | What is obfuscated code?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/safer-buffer@2.1.2. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@huhuanming huhuanming marked this pull request as draft January 23, 2026 12:03
auto-merge was automatically disabled January 23, 2026 12:03

Pull request was converted to draft

@huhuanming huhuanming marked this pull request as ready for review January 26, 2026 14:14
@huhuanming huhuanming enabled auto-merge (squash) January 26, 2026 14:17
@originalix originalix disabled auto-merge January 26, 2026 15:40
@originalix originalix merged commit 81c88c8 into x Jan 26, 2026
9 checks passed
@originalix originalix deleted the chore/upgrade-electron-39.3.0 branch January 26, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@originalix originalix originalix approved these changes

@ezailWang ezailWang Awaiting requested review from ezailWang ezailWang is a code owner

@revan-zhang revan-zhang Awaiting requested review from revan-zhang revan-zhang is a code owner

@sidmorizon sidmorizon Awaiting requested review from sidmorizon sidmorizon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huhuanming @revan-zhang @originalix