Fix to run on .NET Core 3.0 #443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edyoung
commented
Apr 27, 2019
| il.Emit(OpCodes.Ldstr, instanceMethod.ToSignatureString()); | ||
| il.LoadLocation(exc.LocalIndex); | ||
| il.Call(onUnhandledException); | ||
| il.CallVirtual(onUnhandledException); |
Collaborator
Author
There was a problem hiding this comment.
this is the actual fix - the rest is fixing a typo, Virutal instead of Virtual
Collaborator
Author
9 tasks
rjmholt
approved these changes
Apr 28, 2019
SteveL-MSFT
approved these changes
Apr 29, 2019
Collaborator
Author
|
It would only actually to call the OnUnhandledException method if there was
an exception. I haven't provoked that problem and checked what happened -
the error came when trying to JIT the dynamic method.
What do we need to unblock your work - does this need to be formally
released or...?
…On Mon, Apr 29, 2019 at 10:47 AM Steve Lee ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#443 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAALECWRGXP6SLBUPC7VL5LPS4YBJANCNFSM4HI5H4QQ>
.
|
Contributor
|
@edyoung yes, we pick up PackageManagement from PSGallery at build time, so it would be great if you can publish it there, then I can update the version we pick up manually in our 3.0 working branch. Just ping me once it's published. Our master branch will pick it up automatically, but not working branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GenerateMethodForDirectCall creates an IL wrapper for a method in the provider. It allows a function OnUnhandledException to be defined in the interface and implemented in the provide. The generated code calls OnUnhandledException if there is an exception. However the methodInfo for the OUE method is from the interface so needs to be called as a virtual method. It looks like .NET Core 3.0 tightens up IL validation and now throws a "Bad IL Format" exception for this, where in .NET Core 2.0 it let it slide.
1-line fix is to CallVirtual instead of Call.
I believe this is a latent bug in our code. We could still raise it with the CoreFx team I guess since it is a change in behavior that could break others (and servicing packagemanagement with this issue could be interesting, since we can't download the new version with a broken version. But we should fix in any case.