fix(desktop): restore per-session turn clock dropped by the sync + gate renderer tests in CI#160
Merged
Merged
Conversation
…ed + gate renderer tests in CI The running-turn timer's per-session clock (upstream NousResearch#41182) was clipped by the upstream-sync's internal merge (e866446): ClientSessionState.turnStartedAt and its tests survived, but all six seed/clear sites in use-message-stream.ts and the view-sync mirror in use-session-state-cache.ts vanished — so the statusbar timer never starts, and a backgrounded turn's elapsed time zeroes on focus (the exact bug NousResearch#41182 fixed). Restored all seven sites to upstream's shape. Renderer suite: 602/602 (first fully-green run; also passes under TZ=UTC). Because nothing in CI ran this suite, the clobber merged silently — same class as the sleep/wake-recovery loss (#148). Add renderer-tests.yml gating `vitest run --environment jsdom src` on every PR so the next one can't. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
🔎 Lint report:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression (user-visible): the statusbar running-turn timer is dead on main — and a backgrounded turn's elapsed time zeroes when you focus it (the exact bug upstream NousResearch#41182 fixed). The sync's internal merge (
e866446df) clipped the implementation while the type + tests survived: all 6turnStartedAtseed/clear sites inuse-message-stream.tsand the view-sync mirror inuse-session-state-cache.tswere gone (git log -Smisses it because merge commits hide content drops).Fix: restored all 7 sites to upstream/main's exact shape.
use-session-state-cachetests 3/3; full renderer suite 602/602 — first fully-green run (also green underTZ=UTC).Prevention: this is the third silent renderer clobber today (sleep/wake recovery, ghost-pin rollback, now the turn clock) — all merged invisibly because CI never ran the vitest suite. Adds
renderer-tests.ymlgatingvitest run --environment jsdom srcon every PR (scoped tosrc/; theelectron/*.cjsfiles arenode --testand vendorednode-ptyisn't collectible).