fix(desktop): hide sidebar timestamp while a session is active (orange dot is the cue)#137
Merged
Merged
Conversation
#133 made the relative timestamp always-visible on every row, but applied it globally — including active sessions, which already advertise 'running' via the pulsing orange status dot on the left. The result was a redundant '13h' next to the live dot. Hide the timestamp for the duration of an active run; keep its width reserved (opacity-0, not unmounted) so the 3-dot actions menu still lands in the same spot on hover and the row height never shifts. Idle rows keep the #133 behavior (timestamp visible, slides aside for the menu on hover). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
🔎 Lint report:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On an active session row the sidebar showed both the pulsing orange "running" dot (left) and the relative timestamp (right, e.g.
13h) — redundant, and the operator flagged it as a bug. #133 had made the timestamp always-visible on every row in response to "show the timestamp even without hovering," but applied it globally including active rows. The original intent (Wave 1.5 / #127) was for the orange dot to be the sole status cue on active rows.What changed
apps/desktop/src/app/chat/sidebar/session-row.tsx: the trailing-slot timestamp is nowopacity-0whileisWorking. It stays mounted (width reserved) rather than unmounted, so the 3-dot actions menu still lands in the same spot on hover and the row height never shifts. Idle rows are unchanged — timestamp visible at rest, slides left on hover/focus while the menu slides in from the right. Transition widened to[transform,opacity]so the hide is smooth if a row transitions active→idle live.How to review
isWorking && 'opacity-0'addition on the age<span>and the updated slot comment.right-1) is independent of the timestamp, so active rows still get pin/archive/delete on hover.Evidence
Verification
apps/desktop:tsc -b0 errors;vitestchat/sidebar + chat-messages suites — 42 passed. Built into the packaged app and swapped onto the running install for visual confirmation.Risks / gaps
Collaborators