64 bit: fix test failures#27
Closed
fzi-haxel wants to merge 3 commits intoOlegHahm:pr/64bit-preparationfrom
Closed
64 bit: fix test failures#27fzi-haxel wants to merge 3 commits intoOlegHahm:pr/64bit-preparationfrom
fzi-haxel wants to merge 3 commits intoOlegHahm:pr/64bit-preparationfrom
Conversation
f6981dd to
e46d674
Compare
OlegHahm
reviewed
Dec 22, 2023
e46d674 to
76e928a
Compare
Author
|
Added changes a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
sizeof(uintptr_t) == sizeof(uint32_t)does not implyPRIx32 == PRIxPTR.While it worked for x86-gcc, the arm-gcc resolves
uintptr_ttounsigned intanduint32_ttounsigned long.PRIuSIZEformat specifiersunsignedcastsize_ttounsignedtype change foradd_buf_sizedue tofib_get_next_hop(..., &add_buf_size, ...)call. I was a bit to eager with this changeTesting procedure
flashpage-test: BOARD=iotlab-m3 make -C tests/periph/flashpage
Others: Compiled all examples and tests for avr-rss2, iotlab-m3, esp32-wroom-32, native and "native64"