Move ValidateAttestationTime earlier for sync#6755
Merged
Conversation
prestonvanloon
approved these changes
Jul 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Moved
ValidateAttestationTimebefore validation steps that required attestation beacon state.Reasons:
1.) It's a cheaper check (not state required)
2.) During long no finality periods, a node could potentially be attacked by receiving attestations that's outside of
ATTESTATION_PROPAGATION_SLOT_RANGE. Although invalid attestation will fail atValidateAttestationTime, but due toValidateAttestationTimecheck is afterAttestationPreState, the node would be working extra to retrieve the pre state but later finding out that the attestation is invalidOther notes for review
Tested run time