Skip to content

proper error checking and type assertions#5424

Merged
prylabs-bulldozer[bot] merged 1 commit into
masterfrom
typeAssertionsAndErrChecks
Apr 14, 2020
Merged

proper error checking and type assertions#5424
prylabs-bulldozer[bot] merged 1 commit into
masterfrom
typeAssertionsAndErrChecks

Conversation

@farazdagi

Copy link
Copy Markdown
Contributor

Resolves #5404

Changes introduced are trivial but there're a lot of them.

@farazdagi farazdagi self-assigned this Apr 14, 2020
@farazdagi farazdagi marked this pull request as ready for review April 14, 2020 16:23
@farazdagi farazdagi requested a review from a team as a code owner April 14, 2020 16:23

@prestonvanloon prestonvanloon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you

@codecov

codecov Bot commented Apr 14, 2020

Copy link
Copy Markdown

Codecov Report

Merging #5424 into master will increase coverage by 5.54%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5424      +/-   ##
==========================================
+ Coverage   47.43%   52.98%   +5.54%     
==========================================
  Files         266      283      +17     
  Lines       25291    22584    -2707     
==========================================
- Hits        11997    11966      -31     
+ Misses      11321     8885    -2436     
+ Partials     1973     1733     -240     

@prylabs-bulldozer prylabs-bulldozer Bot merged commit 748d513 into master Apr 14, 2020
@delete-merged-branch delete-merged-branch Bot deleted the typeAssertionsAndErrChecks branch April 14, 2020 16:41
@farazdagi farazdagi mentioned this pull request Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle errors and type assertions in test code

4 participants