Remote wallet#5144
Closed
alonmuroch wants to merge 6 commits into
Closed
Conversation
|
|
Merged
| import ( | ||
| "context" | ||
| "fmt" | ||
| "github.com/prysmaticlabs/prysm/shared/bls" |
Contributor
Author
There was a problem hiding this comment.
what do you mean?
Member
There was a problem hiding this comment.
Please run goimports -w validator/client/validator_aggregate.go these imports are not sorted properly.
| return bls.SignatureFromBytes(r.Sig) | ||
| } | ||
|
|
||
| // SignSlot signs an aggregate attestation for the validator to broadcast. |
Collaborator
There was a problem hiding this comment.
Suggested change
| // SignSlot signs an aggregate attestation for the validator to broadcast. | |
| // SignSlot signs the selection proof of an aggregated attestation for the validator to broadcast. |
| c := RW.NewRemoteWalletClient(conn) | ||
|
|
||
| km := &RemoteWallet{ | ||
| keys: make([][48]byte,0), |
Collaborator
There was a problem hiding this comment.
can we define 48 as a constant somewhere?
Contributor
Author
There was a problem hiding this comment.
I was thinking that as well. It makes a lot of sense.
I'll try and do a different PR for that
| Url string `json:"url"` | ||
| } | ||
|
|
||
| // TODO |
| importpath = "github.com/wealdtech/go-indexer", | ||
| ) | ||
|
|
||
| local_repository( |
Member
|
Is this PR relevant #5133? |
Contributor
Author
|
@prestonvanloon I saw you merged @mcdee PR so I guess this one is irrelevant. |
Member
|
Alright, thanks @alonmuroch! Closing this in favor of #5133 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PR for remote wallet key manager
TODO(you): choose "part of" or "resolves" and the associated github issue #.
[Part of|Resolves] #531
Description
Write why you are making the changes in this pull request
Write a summary of the changes you are making
Link anything that would be helpful or relevant to the reviewers