double proposal detector#5120
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5120 +/- ##
========================================
Coverage ? 2.67%
========================================
Files ? 217
Lines ? 15467
Branches ? 0
========================================
Hits ? 414
Misses ? 15007
Partials ? 46 |
rauljordan
reviewed
Mar 17, 2020
rauljordan
reviewed
Mar 17, 2020
4 tasks
nisdas
reviewed
Mar 19, 2020
| defer span.End() | ||
| epoch := helpers.SlotToEpoch(incomingBlk.Header.Slot) | ||
| //TODO(#5119) remove constand and use input from block header. | ||
| //validatorIdx:=blk.Header.ProposerIndex |
Contributor
Author
There was a problem hiding this comment.
we still don't have proposer index in the block header
Contributor
Author
There was a problem hiding this comment.
would like to use stub till we get v0.11 merged
nisdas
approved these changes
Mar 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Part of] #5116