Skip to content

Remove legacy Version0 blob proof support now that Fusaka has launched#4111

Merged
Tristan-Wilson merged 1 commit into
remove-blob-sidecars-readingfrom
remove-non-cell-proof-blob-tx
Dec 4, 2025
Merged

Remove legacy Version0 blob proof support now that Fusaka has launched#4111
Tristan-Wilson merged 1 commit into
remove-blob-sidecars-readingfrom
remove-non-cell-proof-blob-tx

Conversation

@Tristan-Wilson

@Tristan-Wilson Tristan-Wilson commented Dec 4, 2025 •
edited by joshuacolvin0
Loading

Copy link
Copy Markdown
Member

related to NIT-4182

The Fusaka hard fork made cell proofs (Version1) universally required, so the legacy single-proof-per-blob (Version0) code path is no longer needed.

  • Remove enableCellProofs parameter from ComputeProofs(), always use cell proofs
  • Remove EnableCellProofs config field and --enable-cell-proofs flag
  • Remove shouldEnableCellProofs() function from data_poster.go
  • Remove SupportsCellProofs() function from parent.go
  • Remove Version0 tests

@Tristan-Wilson
Remove legacy Version0 blob proof support now that Fusaka has launched
3df0d2e 
The Fusaka hard fork made cell proofs (Version1) universally required, so
the legacy single-proof-per-blob (Version0) code path is no longer needed.

- Remove enableCellProofs parameter from ComputeProofs(), always use cell proofs
- Remove EnableCellProofs config field and --enable-cell-proofs flag
- Remove shouldEnableCellProofs() function from data_poster.go
- Remove SupportsCellProofs() function from parent.go
- Remove Version0 tests
KolbyML
KolbyML approved these changes Dec 4, 2025
View reviewed changes

@KolbyML KolbyML left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: looks good

@github-actions

github-actions Bot commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

❌ 6 Tests Failed:

Tests completed Failed Passed Skipped
2179 6 2173 0
View the top 3 failed tests by shortest run time 
TestDataStreaming_PositiveScenario/Many_senders,_long_messages
Stack Traces | 0.190s run time 
=== RUN   TestDataStreaming_PositiveScenario/Many_senders,_long_messages
WARN [12-04|15:59:04.182] Served datastreaming_start               conn=127.0.0.1:36488 reqid=5 duration="183.944µs" err="we have already seen this request; aborting replayed protocol"
INFO [12-04|15:59:04.182] rpc response                             method=datastreaming_start logId=5 err="we have already seen this request; aborting replayed protocol" result={} attempt=0 args="[\"0x6931afc8\", \"0x30\", \"0xd9\", \"0x27e2\", \"0xa\", \"0xe17d66ef7994098acdec01b0bf2a1346b647c5afbe817bb25049a2f56373b9c36c6e48285f1da09eaac717e691669dc279bdf881a9cb4cd020b1708657cc24c201\"]" errorData=null
    protocol_test.go:230: goroutine 286 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.4/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x15687b0, 0xc00052ac40}, {0x154f260, 0xc000b70720}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic.func1()
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:230 +0x14f
        created by github.com/offchainlabs/nitro/daprovider/data_streaming.testBasic in goroutine 278
        	/home/runner/work/nitro/nitro/daprovider/data_streaming/protocol_test.go:223 +0x85
        
    protocol_test.go:230: �[31;1m [] we have already seen this request; aborting replayed protocol �[0;0m
--- FAIL: TestDataStreaming_PositiveScenario/Many_senders,_long_messages (0.19s)

TestDataStreaming_PositiveScenario
Stack Traces | 0.210s run time 
=== RUN   TestDataStreaming_PositiveScenario
--- FAIL: TestDataStreaming_PositiveScenario (0.21s)

TestPrimaryToSecondaryFailover
Stack Traces | 5.430s run time 
=== RUN   TestPrimaryToSecondaryFailover
=== PAUSE TestPrimaryToSecondaryFailover
=== CONT  TestPrimaryToSecondaryFailover
INFO [12-04|15:58:58.960] arbitrum websocket broadcast server is listening address=[::]:42725
    broadcastclients_test.go:206: Primary broadcaster listening on: [::]:42725
INFO [12-04|15:58:58.961] arbitrum websocket broadcast server is listening address=[::]:38399
    broadcastclients_test.go:207: Secondary broadcaster listening on: [::]:38399
    broadcastclients_test.go:230: Primary URL: ws://127.0.0.1:42725
    broadcastclients_test.go:231: Secondary URL: ws://127.0.0.1:38399
INFO [12-04|15:58:58.961] connecting to arbitrum inbox message broadcaster url=ws://127.0.0.1:42725
INFO [12-04|15:58:58.963] Feed connected                           feedServerVersion=2 chainId=1234 requestedSeqNum=0
    broadcastclients_test.go:278: Phase 1: Sending messages from primary broadcaster
INFO [12-04|15:59:04.172] secondary feed started                   url=ws://127.0.0.1:38399 startingFromSeq=4
INFO [12-04|15:59:04.172] connecting to arbitrum inbox message broadcaster url=ws://127.0.0.1:38399
INFO [12-04|15:59:04.172] Feed connected                           feedServerVersion=2 chainId=1234 requestedSeqNum=4
    broadcastclients_test.go:308: Timed out waiting for message 5/5 from primary
--- FAIL: TestPrimaryToSecondaryFailover (5.43s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@Tristan-Wilson Tristan-Wilson merged commit 377e451 into remove-blob-sidecars-reading Dec 4, 2025
17 checks passed
@Tristan-Wilson Tristan-Wilson deleted the remove-non-cell-proof-blob-tx branch December 4, 2025 16:44
@Tristan-Wilson Tristan-Wilson mentioned this pull request Dec 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KolbyML KolbyML KolbyML approved these changes

@joshuacolvin0 joshuacolvin0 Awaiting requested review from joshuacolvin0

Assignees

@joshuacolvin0 joshuacolvin0

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Tristan-Wilson @KolbyML @joshuacolvin0