Skip to content

Port - Add support for ArbOS51#4073

Merged
joshuacolvin0 merged 2 commits into
v3.9.x-releasefrom
arbos51-port
Nov 26, 2025
Merged

Port - Add support for ArbOS51#4073
joshuacolvin0 merged 2 commits into
v3.9.x-releasefrom
arbos51-port

Conversation

@joshuacolvin0

@joshuacolvin0 joshuacolvin0 commented Nov 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Add consensus-v51 to docker image

@github-actions

github-actions Bot commented Nov 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
2165 2 2163 0
View the top 2 failed tests by shortest run time 
TestVersion30
Stack Traces | 9.450s run time 
... [CONTENT TRUNCATED: Keeping last 20 lines]
�[38;5;48;1myay!! we validated block 23 in 270.84ms�[0;0m
�[34;1mCalling the ArbosTest precompile (Rust => precompile)�[0;0m
    precompile_inclusion_test.go:90: goroutine 455296 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.4/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40c3390, 0xc064b24fc0}, {0x4080d00, 0xc113bd3ad0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc064b24fc0, {0x4080d00, 0xc113bd3ad0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1790 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc064b24fc0, 0x1e, {0xc130949db0, 0x6, 0x4f5dc9?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion30(0xc064b24fc0?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:67 +0x798
        testing.tRunner(0xc064b24fc0, 0x3d09618)
        	/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion30 (9.45s)

TestVersion40
Stack Traces | 10.170s run time 
... [CONTENT TRUNCATED: Keeping last 20 lines]
�[34;1mChecking storage after call tree with CALL�[0;0m
�[34;1mChecking storage after call tree with DELEGATECALL�[0;0m
    precompile_inclusion_test.go:90: goroutine 455297 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.4/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40c3390, 0xc064b25180}, {0x4080d00, 0xc14f2f7260}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc064b25180, {0x4080d00, 0xc14f2f7260}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1790 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc064b25180, 0x28, {0xc124f19df8, 0x5, 0x39?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion40(0xc064b25180?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:71 +0x64b
        testing.tRunner(0xc064b25180, 0x3d09620)
        	/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion40 (10.17s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

tsahee
tsahee approved these changes Nov 26, 2025
View reviewed changes

@tsahee tsahee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tsahee
tsahee approved these changes Nov 26, 2025
View reviewed changes

@tsahee tsahee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 merged commit 8bc5554 into v3.9.x-release Nov 26, 2025
17 checks passed
@joshuacolvin0 joshuacolvin0 deleted the arbos51-port branch November 26, 2025 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tsahee tsahee tsahee approved these changes

Assignees

No one assigned

Labels

design-approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joshuacolvin0 @tsahee