Fix retryable gas calculation bug and add ArbOS51 version (#4047)#4070
Merged
Conversation
735ede4 to
0d80ae1
Compare
* l2pricing: add arbosVersion parameter * create free-storage and use for gas constraints * l2pricing-simulator: build fix * common test: test by default with multiple constraints * fix TestRetryableSubmissionAndRedeemFees * lint fixes * system_test: don't take ownership if no owner * fix more system tests * fix more tests * Add test proving issue with redeem and constraints * Refactor redeem gasPoolUpdateCost to a function * Revert "create free-storage and use for gas constraints" This reverts commit f48b38f. * Correct GasPoolUpdateCost for ArbOS 51 * Increase redeemAllAndCreateAddresses gas for retryable * recreate_rpc: do take ownership * l2pricingstate: restructure arbos version checking * l2pricingmodel: fixes * rework gas constraints * fix typo in test * Post-merge fix: use gasConstraintsMaxNum --------- Co-authored-by: Mikhail Rogachev <mrogachev@offchainlabs.com>
0d80ae1 to
6f6d6e9
Compare
Contributor
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls https://github.com/OffchainLabs/go-ethereum/tree/con5-rel
Port retyrable redeem fix for a consensus-release