Skip to content

Fix backlog update cost in redeem with constraints#4034

Merged
tsahee merged 6 commits into
arbos_51from
fix-retryable-redeem-with-constraints
Nov 21, 2025
Merged

Fix backlog update cost in redeem with constraints#4034
tsahee merged 6 commits into
arbos_51from
fix-retryable-redeem-with-constraints

Conversation

@MishkaRogachev

@MishkaRogachev MishkaRogachev commented Nov 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes NIT-4132

Changes:

  • Limit max number of gas constraints to 20
  • Delegate backlog update cost to L2PricingState and correct costs calculation

@MishkaRogachev MishkaRogachev force-pushed the fix-retryable-redeem-with-constraints branch from 4a97f83 to 449f1cc Compare November 19, 2025 17:37
@github-actions

github-actions Bot commented Nov 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
2172 3 2169 0
View the top 3 failed tests by shortest run time 
TestOutOfGasInStorageCacheFlush
Stack Traces | 7.280s run time 
... [CONTENT TRUNCATED: Keeping last 20 lines]
=== PAUSE TestOutOfGasInStorageCacheFlush
=== CONT  TestOutOfGasInStorageCacheFlush
    program_test.go:2813: goroutine 693102 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.4/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40e32d0, 0xc051c46e00}, {0x40a06a0, 0xc1a8731480}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc051c46e00, {0x40a06a0, 0xc1a8731480}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1790 +0x5d
        github.com/offchainlabs/nitro/system_tests.TestOutOfGasInStorageCacheFlush(0xc051c46e00)
        	/home/runner/work/nitro/nitro/system_tests/program_test.go:2813 +0xfe6
        testing.tRunner(0xc051c46e00, 0x3d27090)
        	/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1997 +0x465
        
    program_test.go:2813: �[31;1m [] failed calculating position for validation: batch not found on L1 yet �[0;0m
INFO [11-21|22:05:21.111] HTTP server stopped                      endpoint=127.0.0.1:38099
TRACE[11-21|22:05:21.111] P2P networking is spinning down
--- FAIL: TestOutOfGasInStorageCacheFlush (7.28s)

TestVersion30
Stack Traces | 7.790s run time 
... [CONTENT TRUNCATED: Keeping last 20 lines]
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1790 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc08b7d4e00, 0x1e, {0xc0987e5db0, 0x6, 0x1?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion30(0xc08b7d4e00?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:67 +0x798
        testing.tRunner(0xc08b7d4e00, 0x3d27568)
        	/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
ERROR[11-21|22:05:46.822] Error pushing sync data from consensus to execution err="context canceled"
--- FAIL: TestVersion30 (7.79s)
�[90mTime to activate storage: 114.100501ms�[0;0m
ERROR[11-21|22:05:46.851] Dangling trie nodes after full cleanup
�[38;5;48;1myay!! we validated block 20 in 113.79ms�[0;0m
�[38;5;48;1myay!! we validated block 9 in 171.20ms�[0;0m
�[38;5;48;1myay!! we validated block 21 in 201.54ms�[0;0m
INFO [11-21|22:05:47.121] HTTP server stopped                      endpoint=127.0.0.1:41171
TRACE[11-21|22:05:47.121] P2P networking is spinning down

TestVersion40
Stack Traces | 8.140s run time 
... [CONTENT TRUNCATED: Keeping last 20 lines]
�[34;1mChecking success (Rust => Solidity => Rust)�[0;0m
�[34;1mChecking call with value (Rust => EOA)�[0;0m
    precompile_inclusion_test.go:90: goroutine 455661 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.4/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40e32d0, 0xc08b7d4fc0}, {0x40a0b20, 0xc05054d440}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc08b7d4fc0, {0x40a0b20, 0xc05054d440}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1790 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc08b7d4fc0, 0x28, {0xc068da5df8, 0x5, 0x39?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion40(0xc08b7d4fc0?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:71 +0x64b
        testing.tRunner(0xc08b7d4fc0, 0x3d27570)
        	/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.4/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion40 (8.14s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@MishkaRogachev MishkaRogachev force-pushed the fix-retryable-redeem-with-constraints branch 4 times, most recently from 9108eea to 707263a Compare November 19, 2025 20:12
@MishkaRogachev MishkaRogachev marked this pull request as ready for review November 19, 2025 20:47
@MishkaRogachev MishkaRogachev changed the title Add test proving issue with redeem and constraints Fix backlog update cost in redeem with constraints Nov 19, 2025
@MishkaRogachev MishkaRogachev marked this pull request as draft November 20, 2025 14:10
@MishkaRogachev

MishkaRogachev commented Nov 21, 2025

Copy link
Copy Markdown
Contributor Author

Close due to https://github.com/OffchainLabs/nitro/pull

@codecov

codecov Bot commented Nov 21, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.23%. Comparing base (2739812) to head (707263a).
⚠️ Report is 8 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (2739812) and HEAD (707263a). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (2739812) HEAD (707263a)
5 2
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #4034       +/-   ##
===========================================
- Coverage   31.70%   18.23%   -13.47%     
===========================================
  Files         445      388       -57     
  Lines       54696    48734     -5962     
===========================================
- Hits        17340     8889     -8451     
- Misses      34220    38156     +3936     
+ Partials     3136     1689     -1447

@MishkaRogachev MishkaRogachev force-pushed the fix-retryable-redeem-with-constraints branch from 707263a to a353499 Compare November 21, 2025 16:43
@MishkaRogachev MishkaRogachev changed the base branch from master to arbos_51 November 21, 2025 16:44
@MishkaRogachev MishkaRogachev marked this pull request as ready for review November 21, 2025 16:45
@tsahee tsahee merged commit a0c187f into arbos_51 Nov 21, 2025
16 checks passed
@tsahee tsahee deleted the fix-retryable-redeem-with-constraints branch November 21, 2025 22:03
@MishkaRogachev MishkaRogachev mentioned this pull request Nov 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshuacolvin0 joshuacolvin0 Awaiting requested review from joshuacolvin0

@tsahee tsahee Awaiting requested review from tsahee

Assignees

@tsahee tsahee

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MishkaRogachev @tsahee