Skip to content

Fix parent chain reader bug in creating smart contract wallet#4019

Merged
joshuacolvin0 merged 1 commit into
masterfrom
fix-scwl1reader-bug
Nov 14, 2025
Merged

Fix parent chain reader bug in creating smart contract wallet#4019
joshuacolvin0 merged 1 commit into
masterfrom
fix-scwl1reader-bug

Conversation

@ganeshvanahalli

Copy link
Copy Markdown
Contributor

This PR fixes a bug where parent chain reader was not started before calling the initialization of smart contract wallet- which could lead to a crash during node startup.

Resolves NIT-3859

@joshuacolvin0 joshuacolvin0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 added this pull request to the merge queue Nov 14, 2025
Merged via the queue into master with commit 889338f Nov 14, 2025
23 of 24 checks passed
@joshuacolvin0 joshuacolvin0 deleted the fix-scwl1reader-bug branch November 14, 2025 23:50
@github-actions

Copy link
Copy Markdown
Contributor

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
2161 4 2157 0
View the top 3 failed tests by shortest run time
TestVersion30
Stack Traces | 7.150s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
=== PAUSE TestVersion30
=== CONT  TestVersion30
    precompile_inclusion_test.go:90: goroutine 455366 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40de510, 0xc088ad0380}, {0x409bd80, 0xc10e7be210}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc088ad0380, {0x409bd80, 0xc10e7be210}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1759 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc088ad0380, 0x1e, {0xc0ea4d7db0, 0x6, 0xc076243c10?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion30(0xc088ad0380?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:67 +0x798
        testing.tRunner(0xc088ad0380, 0x3d22cb8)
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion30 (7.15s)
TestVersion40
Stack Traces | 7.740s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [11-14|22:47:41.858] HTTP server stopped                      endpoint=127.0.0.1:41077
TRACE[11-14|22:47:41.858] P2P networking is spinning down
    precompile_inclusion_test.go:90: goroutine 455367 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.3/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40de510, 0xc088ad0540}, {0x409bd80, 0xc0833bd6b0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc088ad0540, {0x409bd80, 0xc0833bd6b0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1759 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc088ad0540, 0x28, {0xc08444ddf8, 0x5, 0x39?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion40(0xc088ad0540?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:71 +0x64b
        testing.tRunner(0xc088ad0540, 0x3d22cc0)
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.3/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion40 (7.74s)
TestEthSyncing
Stack Traces | 27.600s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
DEBUG[11-14|22:42:12.406] RPC client reconnected                   reading=true  conn=
TRACE[11-14|22:42:12.405] Handled RPC response                     reqid=776  duration="2.515µs"
TRACE[11-14|22:42:12.406] Performed indexed log search             begin=32  end=32  "true matches"=1 "false positives"=0 elapsed="59.411µs"
DEBUG[11-14|22:42:12.407] Pushed sync data from consensus to execution synced=true  maxMessageCount=20  updatedAt=2025-11-14T22:42:12+0000 hasProgressMap=false
TRACE[11-14|22:42:12.406] Handled RPC response                     reqid=3773 duration="1.823µs"
TRACE[11-14|22:42:12.407] Handled RPC response                     reqid=3772 duration="1.863µs"
INFO [11-14|22:42:12.407] Starting work on payload                 id=0x03fff387b39928f6
DEBUG[11-14|22:42:12.407] Served eth_subscribe                     reqid=64   duration="34.755µs"
DEBUG[11-14|22:42:12.407] Served eth_getLogs                       reqid=58   duration="639.089µs"
DEBUG[11-14|22:42:12.407] Executing EVM call finished              runtime="212.116µs"
DEBUG[11-14|22:42:12.407] Executing EVM call finished              runtime="184.115µs"
DEBUG[11-14|22:42:12.407] Served eth_getBlockByNumber              reqid=1078 duration="88.765µs"
TRACE[11-14|22:42:12.407] Handled RPC response                     reqid=63   duration="1.943µs"
DEBUG[11-14|22:42:12.407] Finality not supported, not pushing finality data to execution
DEBUG[11-14|22:42:12.407] Stored state history                     id=5                  block=4   data=164.00B index=239.00B elapsed="48.19µs"
DEBUG[11-14|22:42:12.407] Finality not supported, not pushing finality data to execution
DEBUG[11-14|22:42:12.407] Pushed sync data from consensus to execution synced=true  maxMessageCount=78  updatedAt=2025-11-14T22:42:12+0000 hasProgressMap=false
DEBUG[11-14|22:42:12.407] Finality not supported, not pushing finality data to execution
DEBUG[11-14|22:42:12.407] Pushed sync data from consensus to execution synced=true  maxMessageCount=6   updatedAt=2025-11-14T22:42:12+0000 hasProgressMap=false
--- FAIL: TestEthSyncing (27.60s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants