Skip to content

Instrument multi-gas in account HostIOs#3645

Merged
eljobe merged 4 commits into
masterfrom
instrument-wasm-account-touch-cost-multigas
Sep 17, 2025
Merged

Instrument multi-gas in account HostIOs#3645
eljobe merged 4 commits into
masterfrom
instrument-wasm-account-touch-cost-multigas

Conversation

@MishkaRogachev

Copy link
Copy Markdown
Contributor

Fixes NIT-3796
Waits OffchainLabs/go-ethereum#542

  • Instrument stylus instructions:
    • evm.CallCode
    • evm.DelegateCall
    • evm.StaticCall
  • Add system test in multigas_stylus_program_test.go

require.Greater(t, receipt.MultiGasUsed.Get(multigas.ResourceKindWasmComputation), uint64(0))
}

func TestMultigasStylus_AccountBalance(t *testing.T) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also test the other hostios? You can probably use a test table.

@gligneul gligneul assigned MishkaRogachev and unassigned gligneul Sep 16, 2025
@MishkaRogachev MishkaRogachev force-pushed the instrument-wasm-account-touch-cost-multigas branch from 9b0178f to 3c57c09 Compare September 16, 2025 14:56
gligneul
gligneul previously approved these changes Sep 16, 2025
@gligneul gligneul assigned eljobe and unassigned gligneul Sep 16, 2025
eljobe
eljobe previously approved these changes Sep 16, 2025
@eljobe eljobe dismissed stale reviews from gligneul and themself via a67d4bc September 16, 2025 21:30
@eljobe eljobe enabled auto-merge (squash) September 16, 2025 21:31
@eljobe eljobe merged commit fd72cc9 into master Sep 17, 2025
24 of 25 checks passed
@eljobe eljobe deleted the instrument-wasm-account-touch-cost-multigas branch September 17, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants