Add FloorGasAdditionalTokens to floor-gas computation#3642
Merged
Conversation
e4712e5 to
eef7400
Compare
eljobe
reviewed
Sep 15, 2025
eljobe
left a comment
Member
There was a problem hiding this comment.
I'm happy with the math.
Can you be sure to add some brief context to the PR description?
| // In case floor_gas is used - this negates most of the difference between calldata and batch | ||
| // Raw batch has a 40-byte header that didn't come from calldata (5 uint64s) | ||
| // Calldata for the addSequencerL2BatchFromOrigin call in SequencerInbox, has a function selector | ||
| // and 5 additional fields that don't appear in the aaw batch. |
eljobe
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Account the difference between transaction calldata and raw batches when accounting floorgas