Fix race in DAS chunk assembly by adding per-batch locking#3588
Merged
Tristan-Wilson merged 3 commits intoOffchainLabs:masterfrom Sep 11, 2025
Merged
Fix race in DAS chunk assembly by adding per-batch locking#3588Tristan-Wilson merged 3 commits intoOffchainLabs:masterfrom
Tristan-Wilson merged 3 commits intoOffchainLabs:masterfrom
Conversation
Contributor
prestoalvarez
commented
Sep 8, 2025
- Add a mutex to batch and guard add/close operations to prevent concurrent writes to the same chunk and double increments of seenChunks.
- Eliminates rare “incomplete batch”/flaky assembly caused by data races.
- Scope limited to DAS RPC server; preserves parallelism across different batches.
Tristan-Wilson
approved these changes
Sep 11, 2025
Member
|
@prestoalvarez Thanks for your contribution, this looks like a real bug. |
pmikolajczyk41
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.