Skip to content

Return a fatal error instead of stopping the StopWaiter in case of Er…#3520

Merged
tsahee merged 2 commits intomasterfrom
nit-3549-globalstate-not-in-chain-should-be-a-fatal-error-for
Aug 19, 2025
Merged

Return a fatal error instead of stopping the StopWaiter in case of Er…#3520
tsahee merged 2 commits intomasterfrom
nit-3549-globalstate-not-in-chain-should-be-a-fatal-error-for

Conversation

@alexandrosfilios
Copy link
Contributor

…rGlobalStateNotInChain

@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 22.69%. Comparing base (90570c4) to head (0177eb8).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3520      +/-   ##
==========================================
- Coverage   22.76%   22.69%   -0.07%     
==========================================
  Files         383      383              
  Lines       58196    58200       +4     
==========================================
- Hits        13247    13211      -36     
- Misses      42936    42961      +25     
- Partials     2013     2028      +15     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexandrosfilios alexandrosfilios marked this pull request as ready for review August 19, 2025 15:15
if err != nil {
log.Error("staker: error checking latest confirmed", "err", err)
b.StopWaiter.StopAndWait()
b.fatalErr <- err
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if errors.Is(err, staker.ErrGlobalStateNotInChain)

@alexandrosfilios alexandrosfilios force-pushed the nit-3549-globalstate-not-in-chain-should-be-a-fatal-error-for branch from 208f18a to 0dac3c3 Compare August 19, 2025 15:47
Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee tsahee enabled auto-merge August 19, 2025 16:30
@tsahee tsahee merged commit 6d34456 into master Aug 19, 2025
21 checks passed
@tsahee tsahee deleted the nit-3549-globalstate-not-in-chain-should-be-a-fatal-error-for branch August 19, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants