Skip to content

Optimize sender address derivation#3518

Merged
tsahee merged 3 commits intoOffchainLabs:masterfrom
ian0371:optimize-signer
Aug 19, 2025
Merged

Optimize sender address derivation#3518
tsahee merged 3 commits intoOffchainLabs:masterfrom
ian0371:optimize-signer

Conversation

@ian0371
Copy link
Contributor

@ian0371 ian0371 commented Aug 19, 2025

Use types.Sender() instead of signer.Sender() to utilize cache. It can reduce ecrecover execution time which takes about 31.99% (1.27s out of 3.97s) of ProduceBlockAdvanced().

image

@CLAassistant
Copy link

CLAassistant commented Aug 19, 2025

CLA assistant check
All committers have signed the CLA.

@eljobe eljobe requested a review from tsahee August 19, 2025 20:17
@eljobe eljobe requested a review from magicxyyz August 19, 2025 20:17
@eljobe eljobe assigned magicxyyz and unassigned tsahee Aug 19, 2025
@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 22.64%. Comparing base (4564905) to head (3f1e53a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3518      +/-   ##
==========================================
- Coverage   22.69%   22.64%   -0.05%     
==========================================
  Files         383      383              
  Lines       58200    58200              
==========================================
- Hits        13209    13181      -28     
- Misses      42962    42973      +11     
- Partials     2029     2046      +17     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@tsahee tsahee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@tsahee tsahee enabled auto-merge August 19, 2025 22:45
@tsahee tsahee merged commit 868d8d6 into OffchainLabs:master Aug 19, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants