Skip to content

Close part files after the copy is done#3512

Merged
joshuacolvin0 merged 1 commit intoOffchainLabs:masterfrom
prestonvanloon:close-parts
Aug 18, 2025
Merged

Close part files after the copy is done#3512
joshuacolvin0 merged 1 commit intoOffchainLabs:masterfrom
prestonvanloon:close-parts

Conversation

@prestonvanloon
Copy link
Member

There is no need to keep the file open until the method returns.

Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 22.71%. Comparing base (113654f) to head (fedad72).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3512      +/-   ##
==========================================
+ Coverage   22.67%   22.71%   +0.04%     
==========================================
  Files         383      383              
  Lines       58206    58206              
==========================================
+ Hits        13197    13224      +27     
+ Misses      42977    42955      -22     
+ Partials     2032     2027       -5     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshuacolvin0 joshuacolvin0 merged commit fd1cb43 into OffchainLabs:master Aug 18, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants