Skip to content

Basic seq-coordinator config validation#3489

Merged
joshuacolvin0 merged 2 commits intomasterfrom
seq-coordinator-config-validation
Aug 18, 2025
Merged

Basic seq-coordinator config validation#3489
joshuacolvin0 merged 2 commits intomasterfrom
seq-coordinator-config-validation

Conversation

@Tristan-Wilson
Copy link
Member

seq-coordinator.redis-url must be nonempty if the Sequencer Coordinator is being used.

We had #3441 which could've been avoided with this validation.

Resolves SUP-787

seq-coordinator.redis-url must be nonempty if the Sequencer Coordinator
is being used.
@codecov
Copy link

codecov bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 22.66%. Comparing base (cd0944b) to head (06e3fcb).
⚠️ Report is 144 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3489      +/-   ##
==========================================
+ Coverage   16.61%   22.66%   +6.05%     
==========================================
  Files         375      383       +8     
  Lines       57330    58202     +872     
==========================================
+ Hits         9523    13191    +3668     
+ Misses      46233    42978    -3255     
- Partials     1574     2033     +459     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@MishkaRogachev MishkaRogachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 merged commit 113654f into master Aug 18, 2025
18 of 19 checks passed
@joshuacolvin0 joshuacolvin0 deleted the seq-coordinator-config-validation branch August 18, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants