Skip to content

Lido Split Audit Fix#87

Merged
samparsky merged 6 commits intofeat/auditfrom
feat/lidosplit-audit-fix
Sep 28, 2023
Merged

Lido Split Audit Fix#87
samparsky merged 6 commits intofeat/auditfrom
feat/lidosplit-audit-fix

Conversation

@samparsky
Copy link
Copy Markdown
Contributor

Fixes #76 , Fixes #77

Copy link
Copy Markdown
Contributor

@OisinKyne OisinKyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

ERC20(wstETH).safeTransfer(splitWallet(), amount);
}

/// @notice Rescue stuck ETH
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// @notice Rescue stuck ETH
/// @notice Rescue stuck ETH or ERC20 by pushing to the reward address

I was going to ask should this method have a modifier to protect it, but then realised it didn't matter because the funds can only go one place.

@samparsky samparsky merged commit b27ba37 into feat/audit Sep 28, 2023
@samparsky samparsky deleted the feat/lidosplit-audit-fix branch September 28, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants