Full Migration pysap from Python 2.7 to Python 3#84
Full Migration pysap from Python 2.7 to Python 3#84vah13 wants to merge 1 commit intoOWASP:masterfrom
Conversation
codeHorse87
left a comment
There was a problem hiding this comment.
Hi @vah13 thanks a lot for the PR which looks very promissing. I'm currently quite occupied to conduct a comprehensive review, as well as I'm missing some permission on the repo atm.
I'm not sure if @martingalloar meanwhile can support with the code review meanwhile? I'll do my very best to create a test setup and check with a SAP testing environment.
|
Hello, I can share with you the demo environment of SAP S4 2025 for testing. |
|
@vah13, thanks! Currently totally occupied but when there is some time later I will definitely test with it. Long awaited this thing so thanks for doing this |
|
@codeHorse87 - connect on this? Maybe I can support |
Hi @vah13 thanks for offering. It's not about an SAP system as such but configuring the different test scenarios such as HANA SAML Auth and similar. However, it seems @default-eshu executed full testing and code review including the dependencies already. |
Hi @JonathanStross , |
d36f33f to
4a10a7d
Compare
codeHorse87
left a comment
There was a problem hiding this comment.
version fixing for dependencies updated on request and confirmed.
build and test script verified and tested successfully.
smaller changes reviewed
Full migration of the pysap library to Python 3 with support for Python 3.9 through 3.12 on Linux, macOS and Windows. Core changes: - Replaced deprecated Python 2 imports (cStringIO, SocketServer, Queue) - Ported the pysapcompress C extension to the Python 3 module API - Fixed string vs bytes handling across all SAP protocol modules - Updated the cryptographic routines for proper bytes operations - Resolved scapy 2.7 compatibility issues with duplicate field names Infrastructure: - Modernized the CI/CD pipeline to test against Python 3.9-3.12 - Updated all dependency versions for Python 3 compatibility - Adapted the full test suite to work with Python 3 semantics
|
It's great to see so many traction this big effort! First of all, thank you very @vah13 for the big code push! Since this is going to require some testing, to make sure at the very least the major use cases doesn't break, it's going to require some testing. We cannot expect that we'll get the 100% of the use cases, example scripts and protocols working on the first pass, but we should strive to get it closer to there. I initially started a GitHub project to track that, but since the way the repository is hosted as part of the OWASP organization, it's only visible to certain users with access to that repo, and cannot be made public. I'd suggest we build some sort of quick testing table to document the effort, we can use a Wiki or just this tracking ticket. We can also use the #pysap channel in Discord to coordinate any effort. |
|
Quick update |
codeHorse87
left a comment
There was a problem hiding this comment.
all good. I filed #85 to address some issues with the user guide. Other open tasks are the setup of a new github workflow for build and test.
Local build and test and initial but not comprehensive functional testing don't issue any new findings yet
Full migration of the pysap library to Python 3 with support for Python 3.9 through 3.12 on Linux, macOS and Windows.
Core changes:
Infrastructure: