Merged
Conversation
Merging History-Logger from OWASP
…config file This is done so that the gui can function even if all the arguments are not specified as well as skip reading from the server config file. Changes to be committed: modified: ServerApp/app/__init__.py modified: gui/src/app/security/security.component.ts modified: securetea/args/args_helper.py modified: securetea/args/arguments.py modified: securetea/args/config.py modified: securetea/common.py modified: securetea/core.py
rejahrehim
approved these changes
Jul 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Tackles issue
Added history logger to gui
User's choices of arguments to run SecureTea from GUI are saved and restored
Introduces notifications in gui component
Introduced try-except block for geocode
Todos
Deploy Notes
None specific
Steps to Test or Reproduce
cd ServerApp && sudo python3 run.py
cd gui && ng serve
Impacted Areas in Application
List general components of the application that this PR will affect:
Added history logger option to gui
Arguments : Added arguments :-
1. --skip_input : Skip taking input while running SecureTea App
2. --skip_config_file : Skip taking configuration from config file available on server side
3. Already existing --hist is made false by default
Routes : Added route /notifs for SecureTea app to send notifications to the Server Flask App
Socket : A socket opened between gui and Server Flask App to notify the user regd. attacks, warnings and information from the logger module.