Skip to content

Fix ssl_verify and https detection #126

Merged
dmdhrumilmistry merged 2 commits intoOWASP:devfrom
nrathaus:more_ssl_fixes
Jul 29, 2024
Merged

Fix ssl_verify and https detection #126
dmdhrumilmistry merged 2 commits intoOWASP:devfrom
nrathaus:more_ssl_fixes

Conversation

@nrathaus
Copy link
Copy Markdown
Contributor

This PR fixes - #114

The issues raised by this issue:

  1. ssl_verify wasn't passed everywhere (a mistake)
  2. https isn't used to enable use_ssl, which is bad design

So this fixes:

  1. ssl_verify wasn't passed to all places
  2. 'detect' https and enable use_ssl

dmdhrumilmistry and others added 2 commits July 18, 2024 19:09
2. 'detect' https and enable use_ssl
Copy link
Copy Markdown
Collaborator

@dmdhrumilmistry dmdhrumilmistry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bug fix! 🙌

@dmdhrumilmistry dmdhrumilmistry changed the base branch from main to dev July 29, 2024 12:51
@dmdhrumilmistry dmdhrumilmistry merged commit 849c742 into OWASP:dev Jul 29, 2024
@dmdhrumilmistry dmdhrumilmistry added the bug-fix PR raised for fixing bug label Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix PR raised for fixing bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants