Do not throw error on review comments#48
Merged
orta merged 1 commit intoOSS-Docs-Tools:masterfrom Mar 23, 2025
Merged
Conversation
Collaborator
|
Yeah, this looks good to me 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding comments under a review, the action would previously throw an error due to a
nullbody.Tried looking for the body, but as mentioned in #35, the body of pull request review comments doesn't seem to be documented. The event payload seems to have a
reviewproperty, but it seems to be associated with the overall review rather than a particular review comment.If one truly needed this feature, somebody could iterate through
pulls.listReviewCommentsfor the current PR, and compare it'supdate_atproperty with the current review comment'ssubmitted_atproperty. Although, of course it would lead to bad results if two people comment within the same second. Property values may also be unexpected when updating comments.For now, simply set
bodyso that no crashes occur.