Do not throw error on empty approved review#46
Merged
orta merged 1 commit intoOSS-Docs-Tools:masterfrom Feb 18, 2025
Merged
Conversation
Collaborator
|
This seems very reasonable to me 👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Again!
When performing a GitHub code review, approving the PR with an no typed body would throw an error (would look something like this.
As noted in the code comments, when doing a GitHub review, it is possible to request changes, only comment, or approve. The GitHub web UI only allows successfully sending a review with no body if the PR is "approved".
This fixes that case so no error is thrown. I've tested it here and it seems to work