Skip to content

ci: Update actions and set minimal Node.js version to v14#44

Merged
orta merged 1 commit intoOSS-Docs-Tools:masterfrom
hyperupcall:hyperupcall-ci
Apr 11, 2024
Merged

ci: Update actions and set minimal Node.js version to v14#44
orta merged 1 commit intoOSS-Docs-Tools:masterfrom
hyperupcall:hyperupcall-ci

Conversation

@hyperupcall
Copy link
Copy Markdown
Contributor

In CI, npx jest fails:

$ npx jest
npx: installed 285 in 11.833s
Unexpected token .

This is because actions/setup-node@v1 uses Node.js v10 by default:

$ mise exec node@10 -- npx jest
npx: installed 285 in 15.951s
Unexpected token .

However, tests pass with a minimal Node.js version of v14:

$ mise exec node@14 -- npx jest
npx: installed 285 in 8.205s
PASS  ./index.test.js
  ✓ determine who owns a set of files (13 ms)
  ✓ real world (2 ms)
  ✓ real world 2 (2 ms)
  ✓ real world with labels (2 ms)
  ✓ deciding if someone has access to merge (5 ms)
  githubLoginIsInCodeowners
    ✓ allows folks found in the codeowners (1 ms)
    ✓ ignores case (1 ms)
    ✓ denies other accounts (2 ms)
    ✓ denies subsets of existing accounts (1 ms)

Test Suites: 1 passed, 1 total
Tests:       9 passed, 9 total
Snapshots:   0 total
Time:        0.738 s, estimated 1 s
Ran all test suites.

This PR updates the actions and sets v14 as the default Node.js version installed. Both v14 and v16 are both EOL, so naturally the major version could be bumped if it is not constrained by compatibility concerns.

@orta
Copy link
Copy Markdown
Collaborator

orta commented Apr 11, 2024

Great! Thanks

@orta orta merged commit 311c487 into OSS-Docs-Tools:master Apr 11, 2024
@dmrapp1186
This comment was marked as a violation of GitHub Acceptable Use Policies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants