ci: Update actions and set minimal Node.js version to v14#44
Merged
orta merged 1 commit intoOSS-Docs-Tools:masterfrom Apr 11, 2024
Merged
ci: Update actions and set minimal Node.js version to v14#44orta merged 1 commit intoOSS-Docs-Tools:masterfrom
orta merged 1 commit intoOSS-Docs-Tools:masterfrom
Conversation
Collaborator
|
Great! Thanks |
This comment was marked as a violation of GitHub Acceptable Use Policies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CI,
npx jestfails:This is because
actions/setup-node@v1uses Node.js v10 by default:However, tests pass with a minimal Node.js version of v14:
This PR updates the actions and sets v14 as the default Node.js version installed. Both v14 and v16 are both EOL, so naturally the major version could be bumped if it is not constrained by compatibility concerns.