Do not early return when no relevant code owner exists#40
Merged
orta merged 3 commits intoOSS-Docs-Tools:masterfrom Apr 28, 2024
Merged
Do not early return when no relevant code owner exists#40orta merged 3 commits intoOSS-Docs-Tools:masterfrom
orta merged 3 commits intoOSS-Docs-Tools:masterfrom
Conversation
Contributor
Author
|
The tests pass locally, what does it mean by unexpected token? How can it happen? 🤔 |
Collaborator
|
Hah, no idea about that jest error - maybe a weird npx issue? I think I'd prefer if the label code just moves up above the return instead, mainly so that it's still really obvious that it's not going to accidentally do any work in the fn if no users are found |
Contributor
Author
Isn't it obvious as the code still returns inside |
Collaborator
|
👍🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39
I'd like to have a test but this doesn't really fit into the existing unit tests.