feat(comment): optionally disable comment#544
Open
FalcoSuessgott wants to merge 1 commit intoOP5dev:mainfrom
Open
feat(comment): optionally disable comment#544FalcoSuessgott wants to merge 1 commit intoOP5dev:mainfrom
FalcoSuessgott wants to merge 1 commit intoOP5dev:mainfrom
Conversation
Author
|
alternatively, we could update |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This action currently attempts to overwrite / recreate any previous comments. While this approach is useful for most setups, it leads to race conditions when this actions is being used in a matrix - where one job overwrites the comment of a previous job.
This PR introduces a new boolean argument
post-commentthat if disabled, skips posting the TF diff comment.Users can then instead use the output of the action and implement their own commenting logic:
This approach could also be used to allow posting all diffs in one comment (#535):
Example:
result: