feat: support github enterprise data residency for australia and european union (sweden, netherlands)#454
Merged
rdhar merged 1 commit intoOP5dev:mainfrom May 12, 2025
ArkShocer:feature/ghe-eu-au-v4-fix
Merged
feat: support github enterprise data residency for australia and european union (sweden, netherlands)#454rdhar merged 1 commit intoOP5dev:mainfrom ArkShocer:feature/ghe-eu-au-v4-fix
rdhar merged 1 commit intoOP5dev:mainfrom
ArkShocer:feature/ghe-eu-au-v4-fix
Conversation
rdhar
approved these changes
May 12, 2025
Member
|
Happy to see this shipped with v13.4.0 (v13), where your contribution has been credited! Please consider ⭐ this project, if you or your team find it useful. @ArkShocer BIG thank you for improving GHE support, once again! This area is well-beyond my reach, so your contribution is genuinely appreciated for all Enterprise users of this action. Out of curiosity, as a repeat-contributor, does it make it easier or harder that TF-via-PR is composed in Bash/shell rather than more typical Type/JavaScript? |
Contributor
Author
|
@rdhar Happy to help 😄 I think the majority of the people who would use the action probably know more bash than Type/JavaScript, so I see no issue having it in bash. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix allows the action to be run on the new data residency instances (https://github.com/newsroom/press-releases/data-residency-in-the-eu) which github offers for selected customers. New instances come with the following slug
COMPANY.ghe.com, because of that, I've made an condition which further checks if the token provided hasghe.comin it's parameters.Note, I've only tested these changes on the new
ghe.cominstance, not on agithub.comone.v4 upload
${{ inputs.command == 'plan' && inputs.upload-plan == 'true' && (github.server_url == 'https://github.com' || contains(github.server_url, '.ghe.com')) }}v3 upload
${{ inputs.command == 'plan' && inputs.upload-plan == 'true' && !(github.server_url == 'https://github.com' || contains(github.server_url, '.ghe.com')) }}