Fix broken Header layout on small screens#3798
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
When I set the viewport width to 320px, I see a minor overlap. Should we address this? |
Contributor
Author
|
Thanks Sri. After todays meeting, they were happy to go ahead with the 375px width fix until we move the language link location for mobile in a new task. |
sveltifier
approved these changes
Mar 18, 2026
42b4345 to
d463c02
Compare
d463c02 to
67185c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
The ONS header navigation controls, specifically Menu and Search, become visually misaligned, appearing out of place ONSDESYS-812.
An update to the menu-links class within header.scss was applied to allow for better alignment.
How to review this PR
Go to /components/header/example-header-basic-with-search-and-language and use the toggle device toolbar to reduce the dimensions to iPhone SE. The Menu and Search buttons should be aligned vertically as shown in the screenshots below.
Checklist
This needs to be completed by the person raising the PR.