Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dino-ONS
reviewed
Mar 16, 2026
Contributor
Dino-ONS
left a comment
There was a problem hiding this comment.
Looks good to me. Clean implementation and tests cover the new parameters. Minor suggestion, it would be worth documenting that feedbackLink only applies when using text rather than html, to avoid any confusion.
sveltifier
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
ONSDESYS-804
This PR updates the
phase-bannercomponent to make the feedback link configurable while maintaining compatibility with thehtmlparameter..This change introduces two new optional parameters:
text– plain text content for the bannerfeedbackLink– optional HTML link rendered after the textHow to review this PR
Check new examples added with the new optional parameters and ensure new tests pass
Checklist
This needs to be completed by the person raising the PR.