Header menu should expand instead of overlaying#3796
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
SriHV
approved these changes
Mar 16, 2026
sveltifier
approved these changes
Mar 18, 2026
b25785c to
4f6dbd3
Compare
4f6dbd3 to
915c588
Compare
…lity and organization
915c588 to
018fc86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
When the header menu or search was opened, it overlaid and obscured content below instead of pushing it down. Header Menu and Search overlays page content instead of pushing it down
The ons-header-nav-menu and ons-header-nav-search elements were nested inside the ons-header__top flex row, and used position: absolute taking them out of document flow and causing the overlay behaviour.
To fix layout issues, I moved ons-header-nav-menu and ons-header-nav-search out of the ons-header__top flex container. By making them direct children of the header and placing them after ons-header__top, they now sit in the normal document flow.
How to review this PR
Within the design system, click on Components, Hero, then Example-hero-dark-with-external-breadcrumbs. After opening the page, click the Menu button and it should appear without overlapping the banner.
Checklist
This needs to be completed by the person raising the PR.