Skip to content

Improve earlier fix for inconsistent underlining of highlighted text#3792

Merged
Dino-ONS merged 10 commits intomainfrom
update-ons-highlight
Mar 19, 2026
Merged

Improve earlier fix for inconsistent underlining of highlighted text#3792
Dino-ONS merged 10 commits intomainfrom
update-ons-highlight

Conversation

@Dino-ONS
Copy link
Copy Markdown
Contributor

@Dino-ONS Dino-ONS commented Mar 5, 2026

ONSDESYS-809

Added a fix with regards to the highlighted component question.

How to review this PR

Ensure /components/question/example-question-interviewer-note.html still displays an orange background.

Checklist

This needs to be completed by the person raising the PR.

  • I have selected the correct Assignee
  • I have linked the correct Issue

@Dino-ONS Dino-ONS requested a review from a team as a code owner March 5, 2026 14:07
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
design-system Ready Ready Preview, Comment Mar 19, 2026 9:16am

@sveltifier sveltifier changed the title Update ons Highlight & Components Question Improve earlier fix for inconsistent underlining of highlighted text Mar 5, 2026
@sveltifier sveltifier added the Bug Something isn't working label Mar 5, 2026
@rmccar
Copy link
Copy Markdown
Contributor

rmccar commented Mar 5, 2026

Other than this the VR tests will need updating to reflect the fixing of the interviewer note

@Dino-ONS Dino-ONS force-pushed the update-ons-highlight branch from 05eca73 to 46eca33 Compare March 18, 2026 16:35
@Dino-ONS Dino-ONS merged commit 51b20ef into main Mar 19, 2026
12 checks passed
@Dino-ONS Dino-ONS deleted the update-ons-highlight branch March 19, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants